Update chi to v5.3.1 and implement new chi.Router Query method on http.TracingMux - #172
Merged
Merged
Conversation
… `http.TracingMux` chi v5.3.1 adds `Query` (for the HTTP QUERY method) to the `chi.Router` interface, so `http.TracingMux` no longer compiled against it. Also keep the deprecated `middleware.RealIP` for now with a lint exception, to preserve `RemoteAddr` behavior until a proxy trust model is chosen for the new ClientIP middlewares.
- `google.golang.org/grpc` v1.80.0 => v1.82.1 (GO-2026-6061) - `golang.org/x/text` v0.35.0 => v0.39.0 (GO-2026-5970) - `github.com/aws/aws-sdk-go-v2/service/s3` v1.96.0 => v1.97.3 and `eventstream` v1.7.4 => v1.7.8 (GO-2026-5764) - `go.opentelemetry.io/otel` v1.43.0 => v1.44.0 (GO-2026-5158) - `github.com/jackc/pgx/v5` v5.9.0 => v5.9.2 (GO-2026-5004)
maragubot
added a commit
to maragudk/app
that referenced
this pull request
Jul 29, 2026
Updates `maragu.dev/glue` to the version including maragudk/glue#172, which makes glue compile against chi v5.3.1 (the new `chi.Router` `Query` method). chi moves v5.3.0 → v5.3.1 along with it. This also makes the Compatibility workflow's "latest deps" legs deterministic again: with the new glue pinned in `go.mod`, `go get -u -t ./...` can't resolve a stale pre-fix glue from the module proxy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chi v5.3.1 added
Query(the new HTTP QUERY method) to thechi.Routerinterface, which brokehttp.TracingMux's interface compliance. This is what's failing the "latest deps" legs of the Compatibility workflow in consuming repos:go get -u -t ./...pulls chi v5.3.1 and glue no longer compiles.github.com/go-chi/chi/v5v5.2.5 → v5.3.1 (also picks up the RealIP IP-spoofing fixes GO-2026-5774/5775/5777)http.TracingMux.Query, wrapping the handler with tracing like the other HTTP method registrationsgoogle.golang.org/grpcv1.80.0 → v1.82.1 (GO-2026-6061),golang.org/x/textv0.35.0 → v0.39.0 (GO-2026-5970),github.com/aws/aws-sdk-go-v2/service/s3v1.96.0 → v1.97.3 pluseventstreamv1.7.4 → v1.7.8 (GO-2026-5764),go.opentelemetry.io/otelv1.43.0 → v1.44.0 (GO-2026-5158), andgithub.com/jackc/pgx/v5v5.9.0 → v5.9.2 (GO-2026-5004)One decision deliberately deferred: chi has deprecated
middleware.RealIPoutright because it trusts spoofable headers, in favor of a newClientIP*middleware family (ClientIPFromXFF,ClientIPFromXFFTrustedProxies, etc.) that requires an explicit proxy trust model and never mutatesr.RemoteAddr. Picking a trust model depends on how the apps are deployed, and dropping theRemoteAddrrewrite changes behavior for anything reading it — so this PR keepsmiddleware.RealIPwith anolint:staticcheckand a comment. Happy to do the migration in a follow-up if you tell me the proxy setup in front of your apps.